newrelic / helm-charts

Helm charts for New Relic applications
Apache License 2.0
95 stars 201 forks source link

nri-statsd: Support customSecretName Statsd Chart #1390

Open RoseSecurity opened 4 weeks ago

RoseSecurity commented 4 weeks ago

What and Why

Right now, the nri-statsd chart requires the API key to be hardcoded in the values.yaml or injected during the helm install, but it would be better if a customSecretName could be utilized to reference the secret location like the other nri-bundle elements utilize.

Acceptance Criteria

Before:

global:
   insightsKey: ""

After:

global:
  customSecretName: nri-statsd-key

Checks

RoseSecurity commented 4 weeks ago

@DavSanchez Hello, would this PR accomplish what we discussed here?