[super-agent] Removing inter-chart dependency - Githubissues

newrelic / helm-charts

Helm charts for New Relic applications

Apache License 2.0

95 stars 201 forks source link

[super-agent] Removing inter-chart dependency #1409

Closed paologallinaharbur closed 1 week ago

paologallinaharbur commented 1 week ago

Is this a new chart

no

What this PR does / why we need it:

The Idea is to move the super-agent-deployment dependency to the chart folder so that:

we have only one values
we have only one place for default and readme
it is easier to deploy since we can combine everything in one PR
- I tried as well to move it to the template folder, but I had issues with the common library and to access things behing super-agent-deployment

Special notes for your reviewer:

Focus on the agent-values changes, everything else is a copy paste

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

paologallinaharbur commented 1 week ago

I ended up merging the other PR https://github.com/newrelic/helm-charts/pull/1410 directly to improve readability of this, if the CI fails we can fix it later on