changed cluster & service in metadata - Githubissues

newrelic / infra-integrations-sdk

New Relic Infrastructure Integrations SDK

Apache License 2.0

46 stars 24 forks source link

changed cluster & service in metadata #169

Closed ferranorriols closed 5 years ago

ferranorriols commented 5 years ago

Moved cluster and service to EntityMetadata instead of Entity

Description of the changes

Add a detailed description and purpose of your changes. Link the issue it solves (if there is one).

PR Review Checklist

Author

[ ] add a risk label after carefully considering the "blast radius" of your changes
[ ] describe the intent of your changes in the description. don't just rewrite your code in prose
[ ] assign at least one reviewer

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] ask questions about anything that isn't clear and obvious
[ ] approve the PR when you consider it's good to merge