Enable custom attributes for events - Githubissues

newrelic / infra-integrations-sdk

New Relic Infrastructure Integrations SDK

Apache License 2.0

46 stars 24 forks source link

Enable custom attributes for events #187

Closed alejandrodnm closed 4 years ago

alejandrodnm commented 5 years ago

Description of the changes

This PR allows events with attributes to be decorated with the entity customAttributes when they are added to via the entity.AddEvent function.

PR Review Checklist

Author

[x ] add a risk label after carefully considering the "blast radius" of your changes
[x ] describe the intent of your changes in the description. don't just rewrite your code in prose
[x ] assign at least one reviewer
[x ] document feature

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] request documenation about anything that isn't clear and obvious
[ ] document agent version supporting the feature

mariomac commented 5 years ago

LGTM as long as Juan's comments are addressed

alejandrodnm commented 4 years ago

@varas sorry i missed one of your comments, I replied here https://github.com/newrelic/infra-integrations-sdk/pull/187#discussion_r350369330