Fix JMX logging & error handling - Githubissues

newrelic / infra-integrations-sdk

New Relic Infrastructure Integrations SDK

Apache License 2.0

46 stars 24 forks source link

Fix JMX logging & error handling #188

Closed varas closed 5 years ago

varas commented 5 years ago

Description of the changes

Fix jmx package error handling & improve logging

Disclaimer:

jmx package is poorly designed and will be revamped in the future, this is trying to get it working with minimum effort investment.

PR Review Checklist

Author

[x] add a risk label after carefully considering the "blast radius" of your changes
[x] describe the intent of your changes in the description. don't just rewrite your code in prose
[x] assign at least one reviewer
[ ] document feature

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] request documenation about anything that isn't clear and obvious
[ ] document agent version supporting the feature

varas commented 5 years ago

Related issue https://github.com/newrelic/infra-integrations-sdk/issues/142