Removed panic when log.Fatal is called - Githubissues

newrelic / infra-integrations-sdk

New Relic Infrastructure Integrations SDK

Apache License 2.0

46 stars 24 forks source link

Removed panic when log.Fatal is called #205

Closed alijared closed 4 years ago

alijared commented 4 years ago

Description of the changes

Removed panic call when log.Fatal is called, in favour of just calling os.Exit(1); the same as the standard Go logging library does.

PR Review Checklist

Author

[x] add a risk label after carefully considering the "blast radius" of your changes
[x] describe the intent of your changes in the description. don't just rewrite your code in prose
[x] assign at least one reviewer
[ ] document feature

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] request documentation about anything that isn't clear and obvious
[ ] document agent version supporting the feature

varas commented 4 years ago

changelog update pls

alijared commented 4 years ago

Random test passes on certain runs, but not others. Going to merge anyway as it's not related to these changes