http client accepting invalid hostnames

varas commented 4 years ago

Description of the changes

Package http can now create a client that validate certificates but also accepts invalid hostnames via NewAcceptInvalidHostname.

This addresses issue: https://github.com/newrelic/infra-integrations-sdk/issues/185

PR Review Checklist

Author

[x] add a risk label after carefully considering the "blast radius" of your changes
[x] describe the intent of your changes in the description. don't just rewrite your code in prose
[x] assign at least one reviewer
[x] document feature

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] request documenation about anything that isn't clear and obvious
[ ] document agent version supporting the feature

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: carlosroman
:x: Juan Hernandez

Juan Hernandez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

varas commented 4 years ago

go 1.8 incompatibility on helper :sigh:

newrelic / infra-integrations-sdk