newrelic / instant-observability-website

Dashboards, alerts, and integrations all in one place. Our quickstarts bundle everything you need to start monitoring like a pro right out of the box.

https://newrelic.com/instant-observability/

Apache License 2.0

5 stars 20 forks source link

Begin adding pagination to catalogue #296

Closed aswanson-nr closed 2 years ago

aswanson-nr commented 2 years ago

Summary

Adds pagination to the catalogue page using a "view more" button.

gatsby-cloud[bot] commented 2 years ago

Gatsby Cloud Build Report

instant-observability-website

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 1m

aswanson-nr commented 2 years ago

The "go to top" button doesn't appear until you are pretty far down the page, could we show this earlier? Maybe when the categories are no longer visible?

tabathadelane commented 2 years ago

I was wondering that myself. I will play with some scroll distances.

tabathadelane commented 2 years ago

I'm not sure I love the black on dark gray here with the carousel arrows/guided install background. (This shows on a 2 or 3 column layout - we could also change this setting so the arrow doesn't overlap guided install in any layout if we want to keep the gray. )

legnaleama commented 2 years ago

This is looking good! I like the inclusion of the white border around the "Back to the top" CTA, I'll request the team to add it to the Figma library.

Just a couple of adjustments before we push to master:

[x] Change color of the string "First step" from var(--system-text-muted-light to #00AC69 which is the "Green 2" color on the Erno palette.
[x] Change background color of the "See more button" to transparent to match the Secondary button style in Erno.
[x] Remove hover effect on the wrapper of the "See more button"

@tabathadelane

tabathadelane commented 2 years ago

Just a couple of adjustments before we push to master:

[x] Change color of the string "First step" from var(--system-text-muted-light to #00AC69 which is the "Green 2" color on the Erno palette.

[x] Change background color of the "See more button" to transparent to match the Secondary button style in Erno.

[x] Remove hover effect on the wrapper of the "See more button"

@tabathadelane

Thanks for these notes! I have pushed up the changes. @legnaleama

aswanson-nr commented 2 years ago

Approved

josephgregoryii commented 2 years ago

The back to top button looks soooo much cleaner 👍🏻 great job on this y'all

aswanson-nr commented 2 years ago

Got final design sign off ✅

nr-opensource-bot commented 2 years ago

:tada: This PR is included in version 1.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: