search

newrelic / java-aws-lambda

AWS Lambda OpenTracing Java SDK
Apache License 2.0
11 stars 6 forks source link

startActive was deprecated in opentracing-util 0.32.0 and removed in 0.33.0 #18

Closed jasonjkeller closed 4 years ago

jasonjkeller commented 5 years ago

The TracingRequestHandler and TracingRequestStreamHandler both call startActive which was deprecated in opentracing-util 0.32.0 and removed in 0.33.0.

https://github.com/opentracing/opentracing-java/blob/v0.32.0/opentracing-api/src/main/java/io/opentracing/Tracer.java#L262-L263

We should update these handlers to instead use start and release a new version that supports opentracing-util 0.33.0 and above.

agarbutt commented 4 years ago

I am attempting to leverage this library in a Java Lambda, and I ran into the dependency issue. See #19 as the documentation needs to be updated at least.

Or better, we start to leverage the newer version of OpenTracing.

jasonjkeller commented 4 years ago

This was address by #29