newrelic / micrometer-registry-newrelic

ARCHIVED. TO SEND MICROMETER METRICS TO NEW RELIC, FOLLOW THE DIRECTION IN THE README.md. Micrometer registry implementation that sends data to New Relic as dimensional metrics.
Apache License 2.0
35 stars 19 forks source link

begin 0.7.0-SNAPSHOT #108

Closed breedx-nr closed 4 years ago

breedx-nr commented 4 years ago

Admin merge, due to snyk breakage caused by transitive dep on guava via testcontainers.

bsideup commented 4 years ago

@breedx-nr we do not have a dependency on Guava in Testcontainers, btw: https://mvnrepository.com/artifact/org.testcontainers/testcontainers/1.15.0-rc2

Maybe that's some other dependency that brings it?

breedx-nr commented 4 years ago

@bsideup Thanks for clarifying, I'm sorry for misspeaking. I should have said "mockserver" instead of "testcontainers". So sorry.

The dependency looks like: mockserver-netty -> mockserver-client-java -> mockserver-core -> com.github.java-json-tools:json-schema-validator -> guava

bsideup commented 4 years ago

No problem at all! We do have Guava internally but it is shaded, so I wanted to point that out (and also double checked that it didn't sneak into our public dependencies by accident 😅 )