newrelic / micrometer-registry-newrelic

ARCHIVED. TO SEND MICROMETER METRICS TO NEW RELIC, FOLLOW THE DIRECTION IN THE README.md. Micrometer registry implementation that sends data to New Relic as dimensional metrics.
Apache License 2.0
35 stars 19 forks source link

Changes to make it possible to extend the functionality of the registry. #138

Closed jcohen closed 1 year ago

jcohen commented 2 years ago

Overview

I have the need to limit the cardinality of metrics published to NR, but I'd like to still track metrics with unlimited cardinality and only limit the metrics sent to the top-N when they are published. In order to accomplish this, this PR introduces changes to the registry and its builder to make it more amenable to extension.

Details

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kford-newrelic commented 2 years ago

@jcohen thank you for this PR submission! We've added this to our backlog and will consider it for a future release. However please keep in mind that we have quite a bit of work on our agent roadmap, so it may take us a while to action this. Thanks again!

kford-newrelic commented 1 year ago

@jcohen thank you for the PR but since we've chosen to close this repo, no further enhancements will be made.