search

newrelic / newrelic-airflow-plugin

Send airflow metrics to New Relic!
Apache License 2.0
25 stars 19 forks source link

PR-2 Plugin configuration from airflow.cfg #32

Open pschrimpf opened 2 years ago

pschrimpf commented 2 years ago

Multiple dimensions Local docker setup

pschrimpf commented 2 years ago

@newrelic/python I would suggest removing the test on python27 This version is outdated since 2020. And the last airflow version supporting python27 is 1.10, which is EOL since June 17, 2021. Would you agree?

TimPansino commented 2 years ago

Python 2.7 is unfortunately something we're going to be stuck supporting for quite some time. A lot of high profile customers for Python still use 2.7, so we're not willing to drop support yet. It looks like the error is a dependency issue, probably should be addressed separately.

What's the purpose of the nr_dim metrics? If they're static from a config file is there any real point in sending them?

pschrimpf commented 1 year ago

Hi @TimPansino, sorry for the late reply. I have been on vacation. I see, I try to get the dependencies working again for 2.7.

The "static dimensions"-feature is a request from the field. They would like to be able to send more information for a given airflow instance, which helps identify, separate, or aggregate the data of multiple airflow instances. As this is now possible via airflow.cfg they could take care of it via a Configuration Management tool for example.

pschrimpf commented 1 year ago

@newrelic/python I fixed the dependency issue for python2.7 - how are we going to proceed? Any other remarks on that PR?

CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.