newrelic / newrelic-android-agent

SDK to enable instrumentation of Android mobile apps in New Relic
Apache License 2.0
14 stars 14 forks source link

[NR-168546] Disable instrumentation of signed artifacts #146

Closed cthomas-newrelic closed 1 year ago

cthomas-newrelic commented 1 year ago

The JAR must be written unchanged if ASM can't parse a signed JAR entry.

codecov[bot] commented 1 year ago

Codecov Report

Merging #146 (3d5a684) into develop (ac94a07) will increase coverage by 0.14%. The diff coverage is 27.02%.

@@              Coverage Diff              @@
##             develop     #146      +/-   ##
=============================================
+ Coverage      53.32%   53.46%   +0.14%     
- Complexity      2882     2884       +2     
=============================================
  Files            304      304              
  Lines          15137    15151      +14     
  Branches        1627     1629       +2     
=============================================
+ Hits            8072     8101      +29     
+ Misses          6235     6211      -24     
- Partials         830      839       +9     
Files Coverage Δ
...a/com/newrelic/agent/compile/ClassTransformer.java 59.60% <90.90%> (+16.25%) :arrow_up:
...lic/agent/android/ClassTransformWrapperTask.groovy 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ywang-nr commented 1 year ago
  1. One of the tests failed in Android CI
  2. Do you want to merge this PR to release branch?