search

newrelic / newrelic-android-agent

SDK to enable instrumentation of Android mobile apps in New Relic
Apache License 2.0
14 stars 14 forks source link

fix: use "\r\n" rather than system newline property #181

Closed cthomas-newrelic closed 6 months ago

cthomas-newrelic commented 8 months ago

For multipart mapping.txt uploads.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.58%. Comparing base (08350fd) to head (2fbbcb7). Report is 13 commits behind head on develop.

:exclamation: Current head 2fbbcb7 differs from pull request most recent head 8a61d15. Consider uploading reports for the commit 8a61d15 to get more accurate results

Files Patch % Lines
...m/newrelic/agent/android/obfuscation/Proguard.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #181 +/- ## ============================================= - Coverage 53.59% 53.58% -0.02% - Complexity 2936 2938 +2 ============================================= Files 306 306 Lines 15385 15393 +8 Branches 1672 1675 +3 ============================================= + Hits 8246 8248 +2 - Misses 6281 6288 +7 + Partials 858 857 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ywang-nr commented 7 months ago

Test is successful, waiting for DEMPLA to let us know when we can merge this PR.

See summary and how to test in this ticket.

ywang-nr commented 7 months ago

@cthomas-newrelic We are good to merge this branch based on the latest test confirmation here