search

newrelic / newrelic-android-agent

SDK to enable instrumentation of Android mobile apps in New Relic
Apache License 2.0
14 stars 14 forks source link

Resolve signed jar issues #190

Closed cthomas-newrelic closed 7 months ago

cthomas-newrelic commented 7 months ago

The exceptions we've seen with signed JAR files (Bouncy Castle, et. al.) were a product of the Jar validation in the JarFile parser. Disabling JAR signing verification allows the plugin to read the classes without issue.

We no longer have to exclude signed JARS from instrumentation, or problematic packages like Bouncy Castle.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 53.57%. Comparing base (25d330d) to head (3c63219).

Files Patch % Lines
...lic/agent/android/ClassTransformWrapperTask.groovy 0.00% 16 Missing :warning:
...a/com/newrelic/agent/compile/ClassTransformer.java 20.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #190 +/- ## ============================================= - Coverage 53.60% 53.57% -0.03% - Complexity 2936 2937 +1 ============================================= Files 306 306 Lines 15388 15393 +5 Branches 1673 1675 +2 ============================================= - Hits 8248 8247 -1 - Misses 6282 6288 +6 Partials 858 858 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.