search

newrelic / newrelic-android-agent

SDK to enable instrumentation of Android mobile apps in New Relic
Apache License 2.0
13 stars 12 forks source link

[NR-177314] Verify config updates on data harvest #241

Closed cthomas-newrelic closed 2 months ago

cthomas-newrelic commented 3 months ago

Working as expected, with a few kinks. Local config updating is awkward and need of refinement. As known, there will always be at least a 1-2 harvest lag in realizing the config changes.

Also, fix missing entity guid hand-off from config response.

Adds/updates tests.

Please merge after approval and all actions pass

ywang-nr commented 2 months ago

Android CI is failed at com.newrelic.agent.android.NewRelicTest > testLogReportingFeature FAILED java.lang.AssertionError at NewRelicTest.java:1088

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/7.4.0@ca4905b). Learn more about missing BASE report.

Files Patch % Lines
...com/newrelic/agent/android/AgentConfiguration.java 71.42% 0 Missing and 2 partials :warning:
...om/newrelic/agent/android/logging/LogReporter.java 50.00% 1 Missing and 1 partial :warning:
...m/newrelic/agent/android/logging/RemoteLogger.java 33.33% 1 Missing and 1 partial :warning:
...ic/agent/android/harvest/HarvestConfiguration.java 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/7.4.0 #241 +/- ## ================================================ Coverage ? 56.10% Complexity ? 3260 ================================================ Files ? 324 Lines ? 16507 Branches ? 1813 ================================================ Hits ? 9261 Misses ? 6250 Partials ? 996 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.