search

newrelic / newrelic-browser-agent

New Relic Browser Agent
Apache License 2.0
77 stars 40 forks source link

feat: Logging feature harvesting #1061

Closed metal-messiah closed 3 months ago

metal-messiah commented 4 months ago

Add harvesting scheduling and retry behaviors to the new logging feature

Overview

This PR is branched from #1059 , review that one first Add harvesting, testing architecture, and tests

Related Issue(s)

NR-251165 https://source.datanerd.us/agents/rum-specs/pull/20

Testing

Added new testing server architecture and new E2E tests

github-actions[bot] commented 4 months ago

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 33.86 kB / 11.85 kB (gzip) 33.85 kB / 11.83 kB (gzip) -0.03% / -0.21% (gzip)
lite async-chunk 49.95 kB / 16.13 kB (gzip) 49.95 kB / 16.13 kB (gzip) 0% / 0% (gzip)
pro loader 54.53 kB / 18.49 kB (gzip) 54.49 kB / 18.43 kB (gzip) -0.08% / -0.3% (gzip)
pro async-chunk 94.98 kB / 28.63 kB (gzip) 95.53 kB / 28.7 kB (gzip) 0.58% / 0.24% (gzip)
spa loader 62.69 kB / 20.98 kB (gzip) 62.64 kB / 20.94 kB (gzip) -0.07% / -0.18% (gzip)
spa async-chunk 110.24 kB / 33.06 kB (gzip) 110.8 kB / 33.13 kB (gzip) 0.5% / 0.21% (gzip)
lite-polyfills loader 127.83 kB / 41.14 kB (gzip) 127.76 kB / 41.13 kB (gzip) -0.06% / -0.03% (gzip)
lite-polyfills async-chunk 64.69 kB / 18.46 kB (gzip) 64.69 kB / 18.46 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 149.97 kB / 47.25 kB (gzip) 149.86 kB / 47.21 kB (gzip) -0.07% / -0.09% (gzip)
pro-polyfills async-chunk 117.29 kB / 30.96 kB (gzip) 117.85 kB / 31.11 kB (gzip) 0.48% / 0.47% (gzip)
spa-polyfills loader 158.22 kB / 49.42 kB (gzip) 158.11 kB / 49.39 kB (gzip) -0.07% / -0.06% (gzip)
spa-polyfills async-chunk 134.29 kB / 35.59 kB (gzip) 134.85 kB / 35.74 kB (gzip) 0.42% / 0.4% (gzip)
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (c573e33) to head (1568642).

Files Patch % Lines
src/features/logging/aggregate/index.js 64.70% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1061 +/- ## ========================================== + Coverage 87.56% 87.66% +0.10% ========================================== Files 162 162 Lines 7180 7198 +18 Branches 1406 1410 +4 ========================================== + Hits 6287 6310 +23 + Misses 778 772 -6 - Partials 115 116 +1 ``` | [Flag](https://app.codecov.io/gh/newrelic/newrelic-browser-agent/pull/1061/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [unit-tests](https://app.codecov.io/gh/newrelic/newrelic-browser-agent/pull/1061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `76.38% <70.58%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Static Badge

Last ran on June 07, 2024 15:11:28 CDT Checking merge of (f8599dd8ab2de84b51125e793cd002e4838394ca) into main (c573e330ea5e7dd97e7293b0f95785cb738cf3f2)

metal-messiah commented 3 months ago

After long discussion, will be transitioning to standardize .log and .wrapLogger

This means no capturing arguments until customer feedback is received. This PR will be closed and the changes will be rolled into the optimization PR for ease of review.