Closed patrickhousley closed 3 months ago
Merging this pull request will result in the following asset size changes: |
Agent | Asset | Previous Size | New Size | Diff |
---|---|---|---|---|---|
lite | loader | 34.71 kB / 12.1 kB (gzip) | 34.71 kB / 12.1 kB (gzip) | 0% / 0% (gzip) | |
lite | async-chunk | 50.09 kB / 16.18 kB (gzip) | 50.09 kB / 16.18 kB (gzip) | 0% / 0% (gzip) | |
pro | loader | 55.24 kB / 18.69 kB (gzip) | 55.24 kB / 18.69 kB (gzip) | 0% / 0% (gzip) | |
pro | async-chunk | 96.12 kB / 28.85 kB (gzip) | 96.12 kB / 28.85 kB (gzip) | 0% / 0% (gzip) | |
spa | loader | 63.18 kB / 21.12 kB (gzip) | 63.18 kB / 21.12 kB (gzip) | 0% / 0% (gzip) | |
spa | async-chunk | 111.23 kB / 33.23 kB (gzip) | 111.23 kB / 33.23 kB (gzip) | 0% / 0% (gzip) | |
lite-polyfills | loader | 128.38 kB / 41.43 kB (gzip) | 128.38 kB / 41.43 kB (gzip) | 0% / 0% (gzip) | |
lite-polyfills | async-chunk | 63.99 kB / 18.45 kB (gzip) | 63.99 kB / 18.45 kB (gzip) | 0% / 0% (gzip) | |
pro-polyfills | loader | 150.57 kB / 47.66 kB (gzip) | 150.57 kB / 47.66 kB (gzip) | 0% / 0% (gzip) | |
pro-polyfills | async-chunk | 116.19 kB / 31.08 kB (gzip) | 116.19 kB / 31.08 kB (gzip) | 0% / 0% (gzip) | |
spa-polyfills | loader | 158.77 kB / 49.82 kB (gzip) | 158.77 kB / 49.82 kB (gzip) | 0% / 0% (gzip) | |
spa-polyfills | async-chunk | 133.16 kB / 35.78 kB (gzip) | 133.16 kB / 35.78 kB (gzip) | 0% / 0% (gzip) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.62%. Comparing base (
03efcf3
) to head (217cc7b
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Last ran on July 01, 2024 10:26:30 CDT
Checking merge of (217cc7b1d420f68af8aef0009a95d695b9114dbf) into main (e2beeedc460a1c2acb33bebec352ea72c6c0c1b7)
Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.
Overview
Redesigned the network expects in our integration tests. Tests can now setup network captures before executing any browser commands. The network capture instances will capture all network traffic for the specific test allowing us to verify how many times a BAM api is called, check for calls to BAM apis happened, and wait for BAM api calls to happen. This resolves the race condition we were seeing with the existing network expects logic and ensures the capture is setup prior to loading the test page.
Related Issue(s)
https://new-relic.atlassian.net/browse/NR-283311
Testing
Two spec files have been updated in this PR to use the new network capture feature in place of the old network expect. You can run those on LT to verify it is working.
Local test results: