Queries with both FACET and TIMESERIES fails on JSON unmarshalling

[dsabsay]

Description

When running a NRQL query that uses both FACET and TIMESERIES, the library returns an error because it cannot encode the results into the structs.

Go Version

go version go1.21.3 darwin/amd64

Current behavior

The following error is returned:

json: cannot unmarshal array into Go struct field NRDBResultContainer.data.Actor.Account.NRQL.otherResult of type nrdb.NRDBResult

Expected behavior

The results are returned without error (as they are in the New Relic UI).

Steps To Reproduce

package main

import (
    "fmt"
    "os"
    "time"

    "github.com/newrelic/newrelic-client-go/v2/newrelic"
    "github.com/newrelic/newrelic-client-go/v2/pkg/nrdb"
)

func threshold(client *newrelic.NewRelic) {
    accountID := 1234567

        // This query fails:
    // query := "SELECT percentile(duration, 95) AS 'foobar' FROM Transaction FACET request.method TIMESERIES 1 hours SINCE '2024-01-17 14:51:00 +0000' UNTIL '2024-01-17 19:51:00 +0000'"

        // These queries work:
    // query := "SELECT percentile(duration, 95) AS 'foobar' FROM Transaction FACET request.method SINCE '2024-01-17 14:51:00 +0000' UNTIL '2024-01-17 19:51:00 +0000'"
    query := "SELECT percentile(duration, 95) AS 'foobar' FROM Transaction TIMESERIES 1 hours SINCE '2024-01-17 14:51:00 +0000' UNTIL '2024-01-17 19:51:00 +0000'"

    resultContainer, err := client.Nrdb.Query(accountID, nrdb.NRQL(query))
    if err != nil {
        fmt.Printf("error: %v\n", err)
    }

    fmt.Printf("resultContainer: %#v\n", resultContainer)
}

func main() {
    key := os.Getenv("NR_API_KEY")
    client, err := newrelic.New(
        newrelic.ConfigPersonalAPIKey(key),
        newrelic.ConfigHTTPTimeout(time.Second*30),
    )
    if err != nil {
        fmt.Println(err)
        return
    }

    threshold(client)
}

Set NR_API_KEY env var. Then use comments to try each of the 3 queries. The first one (with FACET and TIMESERIES) does not work.

[shashank-reddy-nr]

Hi @dsabsay,

• When you use Query1, the response from Nerd Graph(new relic API gateway) will look something as shown in Image1 below. If you observe image1, the otherResult and totalResult values are of list type. However, when you use Query2, the otherResult and totalResult values are of object type as shown in Image2.

• As a consequence, If we want to support both data types then we would need to restructure the datatype to interface, which would be an extremely tedious change, given this is a fragile package, owing to its usecases especially in the CLI.

• Hence, we won't be able to support Query1.

Query1:

SELECT percentile(duration, 95) AS 'foobar' FROM Transaction FACET request.method TIMESERIES 1 hours SINCE '2024-01-17 14:51:00 +0000' UNTIL '2024-01-17 19:51:00 +0000'

Query2:

SELECT percentile(duration, 95) AS 'foobar' FROM Transaction FACET request.method SINCE '2024-01-17 14:51:00 +0000' UNTIL '2024-01-17 19:51:00 +0000'

Image1:

Image2: