newrelic / newrelic-client-go

New Relic Client for the Go programming language
https://newrelic.github.io/observability-as-code
Apache License 2.0
73 stars 89 forks source link

feat(nrql_alert_conditions): Add data_account_id for NRQL alert condition #1184

Closed founddrama closed 4 days ago

founddrama commented 4 days ago

Adds support for the new data_account_id field for NRQL alert conditions. This field already appears as dataAccountId in the nrql block for NRQL alert conditions in the NerdGraph GraphQL API. This new field is entering a limited preview and is feature flagged such that it has customer visibility for read operations, but creates and updates are guarded with the feature flag in the downstream service.

This field is a prerequisite for support being added in the Terraform provider (pull request pending)

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.24%. Comparing base (3ff4ee2) to head (bc91460). Report is 58 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1184 +/- ## ========================================== - Coverage 38.84% 38.24% -0.60% ========================================== Files 86 95 +9 Lines 5612 4787 -825 ========================================== - Hits 2180 1831 -349 + Misses 3266 2781 -485 - Partials 166 175 +9 ``` | [Flag](https://app.codecov.io/gh/newrelic/newrelic-client-go/pull/1184/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/newrelic/newrelic-client-go/pull/1184/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic) | `38.24% <ø> (-0.60%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=newrelic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.