newrelic / newrelic-client-go

New Relic Client for the Go programming language
https://newrelic.github.io/observability-as-code
Apache License 2.0
73 stars 89 forks source link

chore(entities): fix drift with browserapplication properties from entities package #1186

Closed pranav-new-relic closed 2 days ago

pranav-new-relic commented 2 days ago

Background

With #1171 merged, the entities package was cleaned up and the team has been running tests in the New Relic Terraform Provieder with the latest version comprising #1171 (v2.39.1 of the New Relic Go Client) to make sure nothing's broken and everything's running fine.

A tiny little glitch was found in one of these Terraform integration tests run on https://github.com/newrelic/terraform-provider-newrelic/pull/2708.

image

Upon further investigation, the cause was found. This block of code, which may have been manually added (owing to the issues we faced earlier with the entities package in Tutone) kinda got wiped away by our cleanup PR #1171, though we did change the depth of the entity query to 3 - it looks like we need greater depth to get these missing attributes.

However, to save time on the immediate release of the Terraform Provider we ought to do for an NRQL alert condition PR, I shall be adding this code change manually, and once the release is done, in the next few days, I shall create a PR to change the entity query to use depth 4.

You may see in the following screenshot that the failing tests's configuration now works fine after this manual addition.

image image