search

newrelic / newrelic-client-go

New Relic Client for the Go programming language
https://newrelic.github.io/observability-as-code
Apache License 2.0
75 stars 95 forks source link

feat(synthetics): Added support for Synthetics Multi Browser, Multi Devices attributes in few synthetics APIs #1198

Closed shashank-reddy-nr closed 2 months ago

shashank-reddy-nr commented 3 months ago

Background

Recently, Synthetics added a new feature for scripted, step, and simple browser monitors to support multiple browsers and devices, allowing users to choose from various options when running monitors. Until now, we only had the option of choosing one device combination. As per customer requests and Synthetics' requirements to support the same multi-browser/devices functionality in Terraform, So, support terraform changes we need changes in client-go as well. So, made below changes to support this.

Changes

1: Ran tutone and generated synthetics package, which brought browsers, devices fileds. 2: Added integration test cases to validate browsers, devices fields. 3: Sross checked the changes tutone brought in and tested the changes related to these fields along with integration test cases as well.

pranav-new-relic commented 2 months ago
image

LGTM

pranav-new-relic commented 2 months ago

we might need to convert the []s to *[]s later on probably, when the API supports accepting an empty list (to remove browsers and devices)

shashank-reddy-nr commented 2 months ago

Agree, we will do this whenever required