search

newrelic / newrelic-client-go

New Relic Client for the Go programming language
https://newrelic.github.io/observability-as-code
Apache License 2.0
74 stars 93 forks source link

Region Constants reference Deprecated API Endpoints #844

Closed tcgbrett closed 2 months ago

tcgbrett commented 2 years ago

Description

The restBaseURL in pkg/region/region_constants.go refers to api.newrelic.com/v2 which is deprecated for Dashboard interaction. That means the whole Dashboards package can't actually interact with the new NerdGraph API.

Go Version

go version go1.17.2 darwin/amd64

Current behavior

When I use the dashboards package, the URL points to a deprecated endpoint, so the request fails. The failure

error creating dashboard:410 response returned: This endpoint is deprecated: Please see documentation on migrating to NerdGraph, our GraphQL API, here:, https://docs.newrelic.com/docs/new-relic-one/use-new-relic-one/core-concepts/dashboards-api-migration-insights-api-nerdgraph, and check the announcement: https://discuss.newrelic.com/t/important-insights-dashboard-api-end-of-life/149357

I changed my local NR code in pkg/dashboards/dashboard.go to print what the devised URL is, and it does confirm my suspicions. I changed this to a print statement

    url := d.config.Region().RestURL("dashboards.json")
    log.Println("Built URL: ", url)

And it printed: Built URL: https://api.newrelic.com/v2/dashboards.json

Expected behavior

This should interact with a non-deprecated API so it's usable.

Steps To Reproduce

Steps to reproduce the behavior: Try to use client.CreateDashboard(*db) and it will fail.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

tcgbrett commented 2 years ago

... I would not like this issue closed. I would like if someone from NR responded.

michaelprice232 commented 2 years ago

This is affecting us as well so would be keen on a fix

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

gmanandhar-nr commented 2 months ago

The issue is no longer relevant because dashboard package was updated to point to the NerdGraph endpoint sometime in the past. Validated by

  1. Created a dashboard using terraform
  2. Destroyed the dashboard using terraform

Hence, closing this issue.