search

newrelic / newrelic-dotnet-buildpack-tile

This is New Relic Dotnet Extension Buildpack repository for Cloud Foundry.
Apache License 2.0
1 stars 7 forks source link

newrelic "online" buildpack fails to resolve agent 8.30.0.0 due to regex, apps fail to start #5

Closed aegershman closed 2 years ago

aegershman commented 4 years ago

TL;DR the lookup pattern matching for the newrelic buildpack to download the latest newrelic agent is 404ing 😉

We're using 1.1.5 of the newrelic-dotnet-buildpack; when using the "online" (e.g. the not cached version) buildpack, where the buildpack reaches out to download.newrelic.com to get the version of the newrelic agent to use, apps are failing during staging due to the newrelic-dotnot buildpack getting 404's:

We turned on debugging and saw the agent was reaching out to:

http://download.newrelic.com/dot_net_agent/previous_releases/8.30.0.0/SHA256/newrelic-netcore20-agent_8.30.0.0_amd64.tar.gz.sha256

which doesn't exist. However, this does:

http://download.newrelic.com/dot_net_agent/previous_releases/8.30.0/SHA256/newrelic-netcore20-agent_8.30.0.0_amd64.tar.gz.sha256

In /.../newrelic-dotnetcore-extension/.../supply.go it appears a regex is used to consume the latest available newrelic agent listed on download.newrelic.com/... under previous_releases as seen here.

As of writing this, 8.30.0 is the latest agent listed in that previous_releases index; however, the regex the newrelic dotnet buildpack appears to be searching for is 8.30.0.0, which doesn't exist in the previous_releases (though 8.30.0 does), thus the buildpack supply throwing 404's

We've switched to using the cached (nr_dotnetcore_extension_cached) buildpack for now, but anyone who is using the "online" buildpack variant (nr_dotnetcore_extension) would have problems when restaging their dotnet applications unless they pinned the url, version, or until a newrelic agent version of 8.30.0.0 or an x.x.x.x of the newrelic agent were published 👍

thanks for your time all

shahramk commented 2 years ago

@aegershman apologies for missing the original issue. not sure what happened, but I just got the notification for closing the issue. please share the manifest.yml file that you were using

thank you

aegershman commented 2 years ago

No worries at all @shahramk I don't recall, that's okay though it's all good. Thank you though 👍

shahramk commented 2 years ago

@no problem @aegershman - I noticed that you were using version 1.1.5 from May of 2020. There are newer releases after that. This issue was addressed in later releases and is fixed. Please use the latest release from March 2021.