newrelic / newrelic-ios-agent-spm

This repository hosts the Swift Package Manager deployment of the iOS agent
Apache License 2.0
15 stars 9 forks source link

Supporting multiple targets #20

Closed eeshwar-eventogy closed 5 months ago

eeshwar-eventogy commented 1 year ago

If you have a project with multiple targets, there is no way to add the framework to other targets.

Description

For other SPM frameworks, after adding it to my main target, I can go to the other targets general settings, and under Frameworks, Libraries, and Embedded Content I can manually add the new framework. But in the case of NewRelic, it does not appear in this list so can not be added to other targets.

Steps to Reproduce

Add the package via SPM, select the main target. Go to another target > General > Frameworks, Libraries, and Embeded Content Click + to add a new one New Relic is not available.

Expected Behavior

New Relic should be available as a framework to add to other targets.

Your Environment

Swift 5 XCode 14.1 MacOS Ventura 13.0 New Relic Agent 4.7.0

edAtRei commented 1 year ago

This issue is affecting me as well. Would really love to see a fix!

cdillard-NewRelic commented 1 year ago

@eeshwar-eventogy @edAtRei

I've pushed a new public branch to this repository named fix-package-multiple-targets

Can you please try changing your NewRelic SPM dependency in Xcode to use this branch?

This should fix the issue with NewRelic not showing up in the "Frameworks, Libraries, and Embedded Content" area of other targets.

We'll make sure this is fixed in our next tagged releases.

Please keep in mind that you'll want to switch back to integrating NewRelic via release tags when our next release comes out. Keep an eye on our iOS agent release notes for that.

busce commented 1 year ago

@cdillard-NewRelic I tried the fix-package-multiple-targets branch. I can now see the NewRelic Framework on all targets. Thanks

cdillard-NewRelic commented 1 year ago

The fix for this issue is contained within the latest version of the agent. Please update to New Relic iOS agent version 7.4.6.