newrelic / newrelic-ios-agent-spm

This repository hosts the Swift Package Manager deployment of the iOS agent
Apache License 2.0
15 stars 9 forks source link

No such module 'NewRelic' and The signature of “NewRelic.xcframework” cannot be verified #32

Closed ibrahimKoteish closed 5 months ago

ibrahimKoteish commented 1 year ago

Description

  1. Building NewRelic with Xcode 15.0 (beta) is failing due to 👇 (The signature of “NewRelic.xcframework” cannot be verified.)
  2. After adding NewRelic using SPM Xcode still gives me No such module 'NewRelic' check attached

/Users/**/Library/Developer/Xcode/DerivedData/testNewRelic-bhufeyyoobszvucbmqyppsxpdwpi/SourcePackages/artifacts/newrelic-ios-agent-spm/NewRelic/NewRelic.xcframework:1:1 The signature of “NewRelic.xcframework” cannot be verified.

Steps to Reproduce

Create a new SwiftUI Project on Xcode 15.0 and add NewRelic using SPM

Expected Behavior

New Relic Framework added successfully

Relevant Logs / Console output

Check Screenshots

Your Environment

Xcode 15 beta swift-driver version: 1.75.2 Apple Swift version 5.8 (swiftlang-5.8.0.124.2 clang-1403.0.22.11.100) iOS 17

Additional context

Screenshot 2023-06-06 at 11 32 42 Screenshot 2023-06-06 at 11 29 24
madsolar8582 commented 1 year ago

This is related to a change Apple made with no opt-out config (at least for SPM at the moment) to increase the "security of the supply chain".

I've posted on the forums for guidance.

In the meantime, if there is no workaround, could you please provide a timeline for compliance with the Xcode 15 changes? As of this moment, I have to remove New Relic to test on iOS/iPadOS 17 which means I do not have crash reporting, etc.

timsearle commented 1 year ago

Plus 1 to this. We'll need to disable New Relic on our beta iOS 17 branch until a new version of the SDK is shipped.

madsolar8582 commented 1 year ago

Per Apple Developer Relations, privacy impacting SDKs will be required to be signed. Unfortunately, the Verify app dependencies with digital signatures did not cover SPM's options for overriding the current behavior like you can for manually attached XCFrameworks.

theblixguy commented 1 year ago

@madsolar8582 Is it possible to run the codesign command as part of the build phase? For example - https://forums.swift.org/t/swiftpm-binarytarget-dependency-and-code-signing/38953/53

shahzadmajeed commented 1 year ago

Hi,

Could we please share some timeline on when this issue will be addressed so that apps can be built with Xcode 15.0? I really appreciate the help!

-Shahzad

rhys-rant commented 1 year ago

Yep, I can't test our app using NewRelic against the iOS 17 SDK until this is resolved.

madsolar8582 commented 1 year ago

@madsolar8582 Is it possible to run the codesign command as part of the build phase? For example - https://forums.swift.org/t/swiftpm-binarytarget-dependency-and-code-signing/38953/53

Unfortunately I get the same error. I even tried forcing the script to run on all builds and place it before the Link Binary with Libraries build phase.

guilhermemachado-mb commented 1 year ago

Same issue here

zach-fuller commented 1 year ago

Same here

Senthil-Kaliathan commented 1 year ago

I have tried in XCode Version 15.0 beta 2, still having the same issue. Could we please share some timeline on when this issue will be addressed so that apps can be built with Xcode 15.0? I really appreciate the help!

cdillard-NewRelic commented 1 year ago

Hello all, I'm Chris, an engineer with New Relic, sorry for the inconvenience caused by this issue with the framework. We plan to release an update containing Xcode 15 support by mid-July.

laurentaylormarshall commented 1 year ago

Hey @cdillard-NewRelic , just wanted to check in that this is still on track for mid-July, thanks!

akshaaatt commented 1 year ago

Any update on this?

pedrofneves commented 1 year ago

Same here. Any update?

jeffhodsdon commented 1 year ago

Same issue as well. Any update @cdillard-NewRelic ?

cdillard-NewRelic commented 1 year ago

Hello all, New Relic iOS agent 7.4.6 has been released. release link Please update to this version as it includes a fix for framework signing to be compatible with Xcode 15