newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
199 stars 143 forks source link

Add new kafka-clients-metrics-3.7.0 instrumentation #1766

Closed jasonjkeller closed 1 month ago

jasonjkeller commented 7 months ago

Create a new kafka-clients-metrics-3.7.0 instrumentation module to support org.apache.kafka:kafka-clients:3.7.0+.

A new org.apache.kafka:kafka-clients:3.7.0 artifact was released which caused the kafka-clients-metrics-3.0.0 instrumentation verifier to fail with the following:

Execution failed for task ':instrumentation:kafka-clients-metrics-3.0.0:verifyPass_org.apache.kafka_kafka-clients_3.7.0'.
> A failure occurred while executing com.newrelic.agent.instrumentation.verify.VerifyWorkAction
   > Verification FAILED. Instrumentation module kafka-clients-metrics-3.0.0-1.0.jar SHOULD HAVE applied to org.apache.kafka:kafka-clients:3.7.0 and did not. You may need to adjust the range "org.apache.kafka:kafka-clients:[3.0.0,)".
     Verifier output:
     Creating user classloader with custom classpath:
        /home/runner/.gradle/caches/modules-2/files-2.1/org.apache.kafka/kafka-clients/3.7.0/b8f9f75bc3edc06f842dd16071465544198bc045/kafka-clients-3.7.0.jar
        /home/runner/.gradle/caches/modules-2/files-2.1/com.github.luben/zstd-jni/1.5.5-6/f29e8571c4948a5e6409e9780d2f90b9170e615a/zstd-jni-1.5.5-6.jar
        /home/runner/.gradle/caches/modules-2/files-2.1/org.lz4/lz4-java/1.8.0/4b986a99445e49ea5fbf5d149c4b63f6ed6c6780/lz4-java-1.8.0.jar
        /home/runner/.gradle/caches/modules-2/files-2.1/org.xerial.snappy/snappy-java/1.1.10.5/ac605269f3598506196e469f1fb0d7ed5c55059e/snappy-java-1.1.10.5.jar
        /home/runner/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.36/6c62681a2f655b49963a5983b8b0950a6120ae14/slf4j-api-1.7.36.jar

     WeaveViolation{type=EXPECTED_NEW_FIELD_ANNOTATION, clazz=org/apache/kafka/clients/consumer/KafkaConsumer, field=metadata}
     WeaveViolation{type=EXPECTED_NEW_FIELD_ANNOTATION, clazz=org/apache/kafka/clients/consumer/KafkaConsumer, field=metrics}
     WeaveViolation{type=INIT_ILLEGAL_CALL_ORIGINAL, clazz=org/apache/kafka/clients/consumer/KafkaConsumer, method=<init>()V}
     WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=org/apache/kafka/clients/consumer/KafkaConsumer, method=poll(Lorg/apache/kafka/common/utils/Timer;Z)Lorg/apache/kafka/clients/consumer/ConsumerRecords;}
workato-integration[bot] commented 7 months ago

https://new-relic.atlassian.net/browse/NR-235990

obenkenobi commented 1 month ago

New Kafka-clients-metrics-3.7.0 instrumentation module added