search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 143 forks source link

1648 http response fixes #1775

Closed jbedell-newrelic closed 8 months ago

jbedell-newrelic commented 8 months ago

The PR addresses the latest version of each module that handles external HTTP calls. The various wrapper classes used to access the headers of the response have been changed to only hold onto the headers rather than the entire response object.

jbedell-newrelic commented 8 months ago

Resolves https://github.com/newrelic/newrelic-java-agent/issues/1648

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.83%. Comparing base (5d47740) to head (54cb21d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1775 +/- ## ============================================ - Coverage 70.84% 70.83% -0.01% - Complexity 9935 9936 +1 ============================================ Files 825 825 Lines 39826 39826 Branches 6037 6037 ============================================ - Hits 28214 28212 -2 - Misses 8887 8888 +1 - Partials 2725 2726 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vikinghawk commented 2 months ago

is there a reason this change wasn't made to spring_webclient5 as well?

jbedell-newrelic commented 2 months ago

Hi @vikinghawk , thanks for the question. At the time, in order to limit scope and potential impact, we made the decision to only update the latest version for most modules. As a result of your question, we discussed this today and decided to open a new ticket to address it for spring-webclient-5.0 as well. Here is a link to the ticket, so you can follow the progress.

Thanks for getting in touch!