Open meiao opened 3 weeks ago
Attention: Patch coverage is 70.17544%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 70.68%. Comparing base (
f1e9c8c
) to head (592a01d
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overview
This PR adds the ability to specify a cloud resource id to some externals. Having a cloud resource id in a span allows the queried infra entity to be linked to the APM entity.
Note that simply adding the cloud resource id is not enough to make the link. The type of entity must also be supported and instrumented.
To add the cloud resource id, use the new methods
cloudResourceId(String)
available in the builders for DatastoreParameters, MessageConsumeParameters and MessageProduceParameters.This PR also populates this field for DynamoDB externals.
Related Github Issue
Fixes #1802
Testing
Instrumentation tests were already disabled because they were flaky in GHA. Furthermore, while trying to run the tests, an issue was found with some dependencies. So for now the instrumentation tests are on hold.
A new agent integration test was added to test the DynamoDB instrumentation.
Checks