APISupportabilityTest is unnecessarily complicated. It uses InstrumentTestUtils.createTransformerAndRetransformClass, passing in a string method descriptor, when it can use InstrumentTestUtils.retransformClass instead. Given that many tests are added by copying existing tests, we should clean up this unnecessary pattern.
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[ ] Your contributions are backwards compatible with relevant frameworks and APIs.
[ ] Your code does not contain any breaking changes. Otherwise please describe.
[ ] Your code does not introduce any new dependencies. Otherwise please describe.
Overview
APISupportabilityTest
is unnecessarily complicated. It usesInstrumentTestUtils.createTransformerAndRetransformClass
, passing in a string method descriptor, when it can useInstrumentTestUtils.retransformClass
instead. Given that many tests are added by copying existing tests, we should clean up this unnecessary pattern.Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here,
Checks