newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 143 forks source link

When IAST is disabled log security related env and system properties #1879

Closed sdaubin closed 6 months ago

sdaubin commented 6 months ago

Overview

When IAST is disabled, this logs the following at FINE level:

I pulled all of this logging out of the main Agent class and into SecurityAgentConfig.

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here,

Checks

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 70.66%. Comparing base (3362da5) to head (6d834a0).

Files Patch % Lines
...com/newrelic/agent/config/SecurityAgentConfig.java 60.00% 3 Missing and 3 partials :warning:
...-agent/src/main/java/com/newrelic/agent/Agent.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1879 +/- ## ============================================ + Coverage 69.80% 70.66% +0.85% - Complexity 9768 9876 +108 ============================================ Files 828 828 Lines 39838 39848 +10 Branches 6064 6064 ============================================ + Hits 27810 28159 +349 + Misses 9346 8960 -386 - Partials 2682 2729 +47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.