newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 143 forks source link

Minor refactoring of daily logfile rolling job to support all platforms. #1888

Closed jtduffy closed 5 months ago

jtduffy commented 5 months ago

Overview

Resolves #1884 Refactor of the ClearExpiredLogsRunnable constructor to remove the Path param. Uses an alternative method for grabbing the log file name and path.

Update tests.

Testing

The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here,

Checks

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.69%. Comparing base (b582130) to head (ea1ae83). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1888 +/- ## ============================================ + Coverage 70.66% 70.69% +0.02% - Complexity 9876 9878 +2 ============================================ Files 828 828 Lines 39848 39850 +2 Branches 6064 6065 +1 ============================================ + Hits 28160 28172 +12 + Misses 8960 8951 -9 + Partials 2728 2727 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.