codecov-commenter
commented
5 months ago Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
Project coverage is 70.68%. Comparing base (
f1e9c8c) to head (dde2220). Report is 603 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...main/java/com/newrelic/weave/utils/WeaveUtils.java | 0.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1908 +/- ## ============================================ - Coverage 70.68% 70.68% -0.01% + Complexity 9877 9859 -18 ============================================ Files 828 826 -2 Lines 39848 39804 -44 Branches 6064 6062 -2 ============================================ - Hits 28167 28134 -33 + Misses 8954 8947 -7 + Partials 2727 2723 -4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves #1882
This PR introduces a new completable future module
java.completable-future-jdk11, for JREs 11 and higher.The reason for this change was the need to instrument
CompletableFuture.completeAsync, which was introduced in Java 9 and was not part of our previous instrumentation. The new module adds support for this method (all other instrumentation is the same asjava.completable-future-jdk8u40).We decided as a team to have this instrumentation build with Java 11 and apply to Javas 11+. Javas 8-10 will use the existing CF module.
Other things of note:
java.completable-future-jdk8u40module,Skip_SecurityPolicy. This is to prevent JREs 11 and higher from loading the module.WeaveUtilsto allow the weaver to recognize Java 9 and 10 runtimes.