search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
199 stars 143 forks source link

Netty Http2 instrumentation can throw an NPE #1947

Closed jbedell-newrelic closed 2 months ago

jbedell-newrelic commented 3 months ago

Related GTSE: https://new-relic.atlassian.net/jira/software/c/projects/NR/boards/289?selectedIssue=NR-280663

The following line in Http2RequestWrapper can throw an NPE (and thus reporting an invalid error up) when the method is null: httpRequest = HttpConversionUtil.toHttpRequest(msg.stream().id(), msg.headers(), true)

Error message is: method header cannot be null in conversion to HTTP/1.x

We need to understand when/why the method can be null and what to do in that case.

workato-integration[bot] commented 3 months ago

https://new-relic.atlassian.net/browse/NR-280927

jasonjkeller commented 2 months ago

The Netty classes weaved to support HTTP/2 have been refactored which resulted in the removal of the weave class that was causing the NPE.