search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 143 forks source link

Refactor vertx-web to weave Http2ServerConnection #1959

Closed jasonjkeller closed 4 months ago

jasonjkeller commented 4 months ago

Fixes a gap in the vertx-web instrumentation where transactions weren't getting started when handling HTTP/2 requests.

Weaves the io.vertx.core.http.impl.HttpServerConnection interface instead of just the Http1xServerConnection implementation. This results in Http1xServerConnection being weaved as well as the previously un-instrumented Http2ServerConnection implementation.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.59%. Comparing base (7ce4777) to head (ab39281).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1959 +/- ## ============================================ - Coverage 70.61% 70.59% -0.02% - Complexity 9859 9860 +1 ============================================ Files 827 827 Lines 39857 39857 Branches 6068 6068 ============================================ - Hits 28144 28138 -6 - Misses 8983 8991 +8 + Partials 2730 2728 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jasonjkeller commented 2 months ago

Related to https://github.com/newrelic/newrelic-java-agent/issues/1799