search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 144 forks source link

AIT: fix capture artifact when multiple AITs fail #1987

Open meiao opened 4 months ago

meiao commented 4 months ago

Description

When an AIT fails, we capture some info about the test. This info is captured using the upload-artifact action. The step that does it is:

      - name: Capture testing artifacts
        if: ${{ failure() || success() }}
        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # pin@v4
        with:
          name: ${{ github.workflow }}-${{ github.job }}-${{ env.MATRIX }}
          path: |
            agent-integration-tests/testing-artifacts/*

But during execution, it looks like the name is not being properly populated. image

github.workflow seems to resolve to Test Suite - PR, github.job to tests, but it looks like ${{env.MATRIX}} is not populating as we would expect.

Acceptance Criteria

Captured test artifacts have the correct name, matching the test being run.

workato-integration[bot] commented 4 months ago

https://new-relic.atlassian.net/browse/NR-293730