search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 144 forks source link

Add Kinesis Data Streams ARNs [DO NOT MERGE UNTIL CLOUD API MERGED] #2112

Closed obenkenobi closed 3 weeks ago

obenkenobi commented 3 weeks ago

Overview

Do not merge until the Cloud API PR is merged.

Add ARNs for AWS Kinesis spans pointing to specific AWS streams using the span attribute cloud.resource_id.

Related Github Issue

https://github.com/newrelic/newrelic-java-agent/issues/2071

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 80.85106% with 63 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (bbb433f) to head (78cdd53). Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
...om/newrelic/agent/cloud/CloudAccountInfoCache.java 70.73% 7 Missing and 5 partials :warning:
...nt/SuperAgentIntegrationHealthFileBasedClient.java 76.66% 4 Missing and 3 partials :warning:
...c/agent/superagent/SuperAgentIntegrationUtils.java 64.70% 5 Missing and 1 partial :warning:
...ava/com/newrelic/agent/utilization/DockerData.java 64.70% 4 Missing and 2 partials :warning:
...in/java/com/newrelic/agent/cloud/CloudApiImpl.java 68.75% 5 Missing :warning:
...gent/config/SuperAgentIntegrationHealthConfig.java 70.58% 4 Missing and 1 partial :warning:
.../agent/config/SuperAgentIntegrationConfigImpl.java 82.35% 0 Missing and 3 partials :warning:
...va/com/newrelic/agent/environment/Environment.java 40.00% 2 Missing and 1 partial :warning:
...a/com/newrelic/agent/transport/DataSenderImpl.java 78.57% 3 Missing :warning:
...ewrelic/agent/cloud/CloudAccountInfoValidator.java 85.71% 1 Missing and 1 partial :warning:
... and 8 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2112 +/- ## ============================================ + Coverage 70.58% 70.65% +0.07% - Complexity 9877 9962 +85 ============================================ Files 829 840 +11 Lines 39947 40253 +306 Branches 6079 6106 +27 ============================================ + Hits 28197 28442 +245 - Misses 9021 9065 +44 - Partials 2729 2746 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.