newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 143 forks source link

support kafka-clients version 3+ #716

Closed averkhovtsev-xm closed 2 years ago

averkhovtsev-xm commented 2 years ago

_Before contributing, please read our contributing guidelines and code of conduct._

Overview

Support kafka-clients version 3.0.0+ This is basically a copy-paste of kafka-clients-metrics-0.10.0.0 instrumentation module.

Related Github Issue

https://github.com/newrelic/newrelic-java-agent/issues/711

Testing

The agent includes a suite of tests which should be used to verify your changes don't break existing functionality. These tests will run with Github Actions when a pull request is made. More details on running the tests locally can be found here,

Checks

[+] Are your contributions backwards compatible with relevant frameworks and APIs? [-] Does your code contain any breaking changes? Please describe. [-] Does your code introduce any new dependencies? Please describe.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

kford-newrelic commented 2 years ago

@averkhovtsev-xm thanks for the Kafka clients PR!

We'll review as soon as we can!

meiao commented 2 years ago

Resolves #711

meiao commented 2 years ago

@averkhovtsev-xm we're going to start working on merging this to our main branch. Though we need you to sign the CLA before we can accept your submission.

averkhovtsev-xm commented 2 years ago

@meiao i've signed the CLA multiple times but it is still pending. what am I doing wrong?

meiao commented 2 years ago

@averkhovtsev-xm probably the email you used for your commit does not match the email in Github. There is a link in the CLAassistant message where you can add the email.

averkhovtsev-xm commented 2 years ago

@meiao I did not find the link you were talking about. I've updated my primary github email to the one used in the commits and did a dummy commit to rerun the cla check. seems to be ok now.

averkhovtsev-xm commented 2 years ago

@meiao some MR checks were not successful, please let me know if this is something I should take care of

meiao commented 2 years ago

Some tests will not pass because it is from a forked repo. Don't worry about it since I will be taking a look at the PR and adding some tests.

averkhovtsev-xm commented 2 years ago

hello @meiao , thanks for merging the MR. do you know when the change is going to be released?

meiao commented 2 years ago

The next release is scheduled to late June.