search

newrelic / newrelic-java-agent

The New Relic Java agent
Apache License 2.0
202 stars 144 forks source link

WebSphere Liberty does not only run on IBM JDKs #842

Open mstoodle opened 2 years ago

mstoodle commented 2 years ago

Description

While researching #841 I came across code in the BootstrapAgent that appears to assume that WebSphere Liberty only runs on IBM JVMs, which is not the case: Liberty can run on e.g. Eclipse Temurin just fine, if slower and using more memory ;) .

I'm not sure if there would be a performance impact but basically all that's required to correct this problem is to remove this if statement; https://github.com/newrelic/newrelic-java-agent/blob/478ccc34989b05f7dce0333c7dc762d574cfa4cf/newrelic-agent/src/main/java/com/newrelic/bootstrap/BootstrapAgent.java#L134

Expected Behavior

Troubleshooting or NR Diag results

Steps to Reproduce

Your Environment

Additional context

(Migrate to Jira)

kford-newrelic commented 2 years ago

Not selected for next quarter's agent roadmap. Will consider for a future agent release.

workato-integration[bot] commented 2 years ago

https://issues.newrelic.com/browse/NEWRELIC-4083