search

newrelic / newrelic-java-kotlin-coroutines

Provides instrumentation for Kotlin Coroutines
Apache License 2.0
1 stars 4 forks source link

Publish ".tgz" along with ".jar" files for release #14

Closed ketronkowski closed 1 year ago

ketronkowski commented 1 year ago

Summary

Releases of this extension are currently provided as jar file artifacts. The New Relic buildpack only supports adding java agent extensions (such as this) that are in gzipped tar format. It would be convenient to be able to specify the URL to this extension packaged as a ".tgz" artifact.

Desired Behavior

It would be desirable to be able to specify the value of BP_NEW_RELIC_EXT_URI for the New Relic Buildpack to be a Gzipped tar release artifact of this repository.

Possible Solution

Zip each jar file artifact and add them to the release artifacts.

Additional context

dhilpipre commented 1 year ago

We can do this but I am wondering does each jar need to be gzipped or can we create a tar file of all the jars and gzip it?

ketronkowski commented 1 year ago

From looking at the code over at buildpack it looks like they basically unzip the contents into a directory and then specify this directory to the agent at runtime.

I am not as familiar with how the java agent extension work, so I am not sure if having multiple jar files in that directory would work.

I do know that one jar in a ".tgz" works. You can see a working example of it in a fork of this repo here.

ketronkowski commented 1 year ago

BTW, I would also be perfectly happy if nr-buildpack was modified to take in a ".jar" file directly. This was mentioned in issue 25 back in 10/2022, but it doesn't seem like there has been any movement on that enhancement since.

dhilpipre commented 1 year ago

Unfortunately I don't have anything to do with the build pack. The extensions directory can contain multiple jar files. I have updated the release artifacts to include both the individual jars gzipped as well as a tarball that contains all of the jars and is gzipped. Hopefully this satisfies your request and we can close this out.