search

newrelic / newrelic-kubernetes-operator

Operator to create New Relic configuration in Kubernetes
Apache License 2.0
43 stars 21 forks source link

fix: namespace's prefix deleted(manager.yaml) #123

Closed kaojiri closed 4 years ago

kaojiri commented 4 years ago

fix: namespace's prefix deleted(manager.yaml)

thande commented 4 years ago

so when I ran this with my original version of kustomize (3.8.2) I was seeing a different

$ diff master.yaml kaojiri-master.yaml
6c6
<   name: newrelic-kubernetes-operator-system
---
>   name: system
$ kustomize version
{Version:3.8.2 GitCommit:e2973f6ecc9be6187cfd5ecf5e180f842249b3c6 BuildDate:2020-08-29T19:15:49+01:00 GoOs:darwin GoArch:amd64}

However, I updated to the latest version of kustomize (3.8.5), no difference found

$ diff master.yaml kaojiri-master.yaml
$ kustomize version
{Version:kustomize/v3.8.5 GitCommit:4052cd4fd8c76a17b5f64e32509f3fba9713fe75 BuildDate:2020-10-08T05:35:40+01:00 GoOs:darwin GoArch:amd64}

I'm concerned that with merging this any users with older versions of kustomize may encounter unexpected issues. Let me check with some others and get a second opinion on this.

thande commented 4 years ago

after further internal discussion among users of this operator and in light of the fact that this is restoring previous behavior before it changed by kustomize, I'll go ahead and merge this.