Support for lost signal and new client

newrelic / newrelic-kubernetes-operator

Operator to create New Relic configuration in Kubernetes

Apache License 2.0

43 stars 21 forks source link

Support for lost signal and new client #136

Closed paologallinaharbur closed 3 years ago

paologallinaharbur commented 3 years ago

Use Case

We are creating a canary environment and we needed to set signal and expiration configs

Decisions

I did not leveraged alerts.AlertsNrqlConditionSignal and alerts.AlertsNrqlConditionExpiration since the json annotation were not adding omit_empty possibly causing a breaking change.

Moreover one of the field was float64 that is not supported and discuraged by the generator

Fix https://github.com/newrelic/newrelic-kubernetes-operator/issues/135

paologallinaharbur commented 3 years ago

@thande pinging you after slack conversation :)

Let me know if the approach is correct, I tried to follow the same structure you had already in place

paologallinaharbur commented 3 years ago

@thande any news on this?