external_id parser logic wrong

newrelic / newrelic-lambda-cli

A CLI to install the New Relic AWS Lambda integration and layers.

https://newrelic.com/products/serverless-aws-lambda

Apache License 2.0

47 stars 53 forks source link

external_id parser logic wrong #199

Closed americanstone closed 2 years ago

americanstone commented 2 years ago

Description

in the case using integration-arn to overwrite the role. external_id = parse_arn(role_arn)["account"] result["resourcetype"], result["resource"] = elements[5].split("/") throw error if role name like arn:aws:iam::xxxxx:role/acct-managed/NewRelicInfrastructure-Integrations

Steps to Reproduce

Expected Behaviour

Relevant Logs / Console output

Your Environment

ex: Browser name and version:
ex: Operating System and version:

Additional context

kolanos commented 2 years ago

Hi @americanstone, why was the issue closed?

americanstone commented 2 years ago

Hi @americanstone, why was the issue closed? I use this one to track https://github.com/newrelic/newrelic-lambda-cli/issues/201