Closed huonw closed 10 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
I think we probably need to upgrade these code URI references too, to the latest version of https://github.com/newrelic/aws-log-ingestion, but I'm not sure how to compute them: https://github.com/newrelic/newrelic-lambda-cli/blob/3732e00485dd96bd627d298477d2f3f3a8a55d8b/newrelic_lambda_cli/templates/import-template.yaml#L62
Hi @umaannamalai and @TimPansino, is there a chance you could take a look at this and let me know if there's a path forward? We've deployed lambda integration via this CLI with Python 3.7 and would prefer to upgrade it using the same method before AWS's November 27 end-of-support deadline. Thank you!
FYI We fixed this, and we're going to try and get approval to release this tomorrow. We're under a code freeze and we'll have to get an exception, if it's not approved then this won't release until the 29th. Sorry for the potential inconvenience.
Thank you!
This fixes #248 by upgrading the Python version from 3.7 to 3.9. 3.7 is going out of support soon (end of November), so this has to happen.
This also requires upgrading a few dev dependencies to newer versions that provide pre-built wheels for 3.9 for my machine. I only upgraded the ones don't build by default on my computer (ARM macOS, with various packages/compilers installed), there are likely others that should be upgraded.
I tried upgrading to even newer versions but these failed to run
pytest
(presumably it and/or other libs need to be upgraded too), plus, it seems the latest version of https://github.com/newrelic/aws-log-ingestion only supports 3.9.Error on 3.10
``` Traceback (most recent call last): File "/opt/homebrew/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main return _run_code(code, main_globals, None, File "/opt/homebrew/Cellar/python@3.10/3.10.10_1/Frameworks/Python.framework/Versions/3.10/lib/python3.10/runpy.py", line 86, in _run_code exec(code, run_globals) File "/Users/huon/projects/newrelic/newrelic-lambda-cli/.venv310/lib/python3.10/site-packages/pytest/__main__.py", line 7, inError on 3.11
``` Traceback (most recent call last): File "/Users/huon/projects/newrelic/newrelic-lambda-cli/.venv/lib/python3.11/site-packages/py/_vendored_packages/apipkg.py", line 141, in __makeattr modpath, attrname = self.__map__[name] ~~~~~~~~~~~~^^^^^^ KeyError: '__spec__' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "I'm not sure how to test accurately, and wonder if further changes may be required.