Closed lavarou closed 1 month ago
Test Suite | Status | Result |
---|---|---|
Multiverse | :white_check_mark: | 9/9 passing |
SOAK | :white_check_mark: | 56/56 passing |
Attention: Patch coverage is 84.61538%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 78.78%. Comparing base (
85d74db
) to head (0af9498
). Report is 5 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
agent/lib_guzzle6.c | 84.61% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Really nicely done! Thanks for addressing this issue.
Couple of tests comments, but otherwise, LGTM.
Modify the onRejected handler to end guzzle's external segment even when there's no response. This allows to mark the span as an external span and capture the uri and method of the request. Additionally when sync requests is rejected, onRejected callback is not called via
PromiseInterface::then
and needs to be called manually.Fixes #320.