Closed hahuja2 closed 2 months ago
Attention: Patch coverage is 94.56522%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 78.17%. Comparing base (
06824b7
) to head (fa99aeb
). Report is 4 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
axiom/nr_errors.c | 85.29% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Test Suite | Status | Result |
---|---|---|
Multiverse | :white_check_mark: | 7/7 passing |
SOAK | :x: | 55/56 passing |
PR #960 supersedes the work in this PR. The conclusion was that the agent spec does not support these current parameters currently as attributes, and much of the information is available from the stack trace or by adding the desired information to the error message passed to the API.
This PR does the following:
nr_txn_record_error_with_additional_attributes
, which takes in the additional parameters that are passed innewrelic_notice_error
and adds them as error attributes.