newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Update NewRelicLogForwardingHandler #1038

Closed TimPansino closed 9 months ago

TimPansino commented 10 months ago

Overview

Related Github Issue

Related to #731

github-actions[bot] commented 10 months ago

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.93s
✅ PYTHON black 5 3 0 0.95s
❌ PYTHON flake8 5 10 0.45s
✅ PYTHON isort 5 4 0 0.18s
✅ PYTHON pylint 5 0 4.16s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2b14392) 81.21% compared to head (8fcc42f) 81.19%.

Files Patch % Lines
newrelic/api/log.py 86.66% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1038 +/- ## ========================================== - Coverage 81.21% 81.19% -0.02% ========================================== Files 190 190 Lines 19728 19745 +17 Branches 3462 3468 +6 ========================================== + Hits 16022 16032 +10 - Misses 2718 2724 +6 - Partials 988 989 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TimPansino commented 9 months ago

I'm thinking while we're in this part of the code we might as well remove the old deprecated NewRelicLogHandler-what do you think?

I think we should do a round up of removing deprecated code and do just one major version bump for a whole batch.