search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Fix Priority Sampling Error Events Test #1054

Closed lrafeei closed 7 months ago

lrafeei commented 9 months ago

Overview

This PR makes the test_priority_used_in_transaction_error_events found in tests/agent_features/test_priority_sampling.py run more consistently. Here, the priority measured can be 1 or 2 depending on the randomness in sampling computation.

github-actions[bot] commented 9 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.58s
✅ PYTHON flake8 1 0 0.36s
✅ PYTHON isort 1 0 0 0.17s
✅ PYTHON pylint 1 0 1.4s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6fd639d) 81.15% compared to head (2ff6304) 81.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1054 +/- ## ========================================== - Coverage 81.15% 81.13% -0.03% ========================================== Files 190 190 Lines 19747 19747 Branches 3468 3468 ========================================== - Hits 16025 16021 -4 - Misses 2732 2735 +3 - Partials 990 991 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lrafeei commented 7 months ago

Nope, still fails, just with less frequency :(

Closing this ticket.