search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
176 stars 99 forks source link

Fix sklearn version tuple parsing in tests #1067

Closed hmstepanek closed 7 months ago

hmstepanek commented 7 months ago

Utilize the common parsing method that already handels non integer versions rather than building our own.

github-actions[bot] commented 7 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 12 0 0 0.89s
✅ PYTHON flake8 12 0 0.5s
✅ PYTHON isort 12 0 0 0.19s
✅ PYTHON pylint 12 0 2.26s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

TimPansino commented 7 months ago

As long as this doesn't fail on non-integer patch versions it looks fine

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (57d2236) 81.22% compared to head (ab54482) 81.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1067 +/- ## ========================================== - Coverage 81.22% 81.19% -0.04% ========================================== Files 190 190 Lines 19745 19745 Branches 3468 3468 ========================================== - Hits 16038 16031 -7 - Misses 2720 2724 +4 - Partials 987 990 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.