search

newrelic / newrelic-python-agent

New Relic Python Agent
https://docs.newrelic.com/docs/agents/python-agent
Apache License 2.0
178 stars 102 forks source link

Add default to pop to guard against key not found #1146

Closed hmstepanek closed 5 months ago

hmstepanek commented 5 months ago

Overview

Pop needs a default value, otherwise it will raise an exception if the key is not found.

github-actions[bot] commented 5 months ago

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 1 0 4.71s
✅ PYTHON black 1 0 0 1.08s
✅ PYTHON flake8 1 0 0.58s
✅ PYTHON isort 1 0 0 0.29s
✅ PYTHON pylint 1 0 3.86s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.45%. Comparing base (93ad043) to head (acd91f1). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1146 +/- ## ========================================== - Coverage 81.71% 81.45% -0.26% ========================================== Files 192 192 Lines 21345 21345 Branches 3715 3715 ========================================== - Hits 17442 17387 -55 - Misses 2818 2869 +51 - Partials 1085 1089 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.